Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Critical error" handling #238

Open
ForNeVeR opened this issue Nov 24, 2022 · 0 comments
Open

"Critical error" handling #238

ForNeVeR opened this issue Nov 24, 2022 · 0 comments
Labels
kind:enhancement New feature or request kind:refactoring Changing the code without changing the user-visible behavior status:help-wanted This issue could use help from the external contributors

Comments

@ForNeVeR
Copy link
Owner

ForNeVeR commented Nov 24, 2022 •
edited
Loading

Right now, me.fornever.avaloniarider.previewer.AvaloniaPreviewerSessionController#getCriticalError signal is sometimes subscribed to, but never properly handled: the session gets terminated momentarily after this signal, so all the error handling we have in me.fornever.avaloniarider.idea.editor.BitmapPreviewEditorComponent#handleCriticalError doesn't really work.

We should refactor this and fix the error handling. Perhaps move it to me.fornever.avaloniarider.idea.editor.AvaloniaPreviewEditorBase.
@ForNeVeR ForNeVeR added kind:enhancement New feature or request status:help-wanted This issue could use help from the external contributors kind:refactoring Changing the code without changing the user-visible behavior labels Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind:enhancement New feature or request kind:refactoring Changing the code without changing the user-visible behavior status:help-wanted This issue could use help from the external contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ForNeVeR