Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust BroadcastStyle handling #43

Merged
merged 1 commit into from
Dec 30, 2023
Merged

More robust BroadcastStyle handling #43

merged 1 commit into from
Dec 30, 2023

Conversation

ToucheSir
Copy link
Member

@ToucheSir ToucheSir commented Dec 29, 2023

This makes use of the officially documented way to change the dimension of a BroadcastStyle. Ref. https://docs.julialang.org/en/v1/manual/interfaces/#writing-binary-broadcasting-rules:

Whenever you subtype AbstractArrayStyle, you also need to define rules for combining dimensionalities, by creating a constructor for your style that takes a Val(N) argument...

Which means we can rely on this being present for all GPU array types.

PR Checklist

  • Tests are added
  • Documentation, if applicable

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (06aba31) 96.40% compared to head (8a6bc82) 96.40%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #43   +/-   ##
=======================================
  Coverage   96.40%   96.40%           
=======================================
  Files           4        4           
  Lines         139      139           
=======================================
  Hits          134      134           
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@darsnack darsnack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failures appear unrelated

@ToucheSir ToucheSir merged commit 3ce8f0e into main Dec 30, 2023
9 of 12 checks passed
@ToucheSir ToucheSir deleted the bc/broadcast-style branch December 30, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants