Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading "No Rx variables in that space" debug message in nested RxBuilder #11

Open
mkc188 opened this issue Jul 16, 2021 · 0 comments

Comments

@mkc188
Copy link

mkc188 commented Jul 16, 2021

When I using nested RxBuilder, I found that the "No Rx variables in that space" debug message could be misleading.

For example, consider the following nested RxBuilder structure. RxBuilderC is the real one which does not have Rx variables. But the debug message is telling me it is RxBuilderD.

It's because the order of RxBuilder's constructor is not the same as RxMixin's untrack(). But I can't find a better way to fix it.

Order of assigning "_stackTrace = StackTrace.current" in RxBuilder's constructor

1  RxBuilderA ──┐
                │
                │
                │
                │
2  RxBuilderB ──┼────── 4  RxBuilderD
                │         (No Rx variable)
                │          WRONG!!!
                │
                │
3  RxBuilderC ──┘



Order of calling untrack(_stackTrace) in RxMixin


1  RxBuilderA ──┐
                │
                │
                │
                │
2  RxBuilderB ──┼────── 3  RxBuilderD
                │
                │
                │
                │
4  RxBuilderC ──┘
  (No Rx variable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant