From b8e6a411c0c0233fe48ec244f326a02322c2c928 Mon Sep 17 00:00:00 2001 From: Iajret <8430839+Iajret@users.noreply.github.com> Date: Thu, 19 Dec 2024 18:53:15 +0300 Subject: [PATCH] Apply suggestions from code review --- code/modules/admin/admin.dm | 7 ++++--- code/modules/admin/verbs/secrets.dm | 8 ++++---- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/code/modules/admin/admin.dm b/code/modules/admin/admin.dm index 2e3646f2978..963e85f1450 100644 --- a/code/modules/admin/admin.dm +++ b/code/modules/admin/admin.dm @@ -1,13 +1,14 @@ //////////////////////////////// -/proc/message_admins(msg, not_to_eventmaker) +/proc/message_admins(msg, not_to_eventmaker) // TFF EDIT. ORIGINAL /proc/message_admins(msg) msg = "ADMIN LOG: [msg]" +// TFF CHANGE START - EVENTMAKERS var/list/addressee = GLOB.admins.Copy() if(not_to_eventmaker) for(var/client/admin in GLOB.admins) if(admin.is_eventmaker()) addressee -= admin - - to_chat(addressee, +// TFF CHANGE END + to_chat(addressee, // TFF EDIT. ORIGINAL GLOB.admins, type = MESSAGE_TYPE_ADMINLOG, html = msg, confidential = TRUE) diff --git a/code/modules/admin/verbs/secrets.dm b/code/modules/admin/verbs/secrets.dm index 01252b4553a..c9779652fd1 100644 --- a/code/modules/admin/verbs/secrets.dm +++ b/code/modules/admin/verbs/secrets.dm @@ -9,7 +9,7 @@ ADMIN_VERB(secrets, R_NONE, "Secrets", "Abuse harder than you ever have before w var/client/holder //client of whoever is using this datum var/is_debugger = FALSE var/is_funmin = FALSE - var/is_eventmaker_admin = FALSE + var/is_eventmaker_admin = FALSE // TFF EDIT - Eventmaker /datum/secrets_menu/New(user)//user can either be a client or a mob due to byondcode(tm) if (istype(user, /client)) @@ -21,8 +21,8 @@ ADMIN_VERB(secrets, R_NONE, "Secrets", "Abuse harder than you ever have before w is_debugger = check_rights(R_DEBUG) is_funmin = check_rights(R_FUN) - is_eventmaker_admin = holder.is_eventmaker() - world.log << is_eventmaker_admin + is_eventmaker_admin = holder.is_eventmaker() // TFF EDIT - Eventmaker + world.log << is_eventmaker_admin // TFF EDIT - Eventmaker /datum/secrets_menu/ui_state(mob/user) return GLOB.admin_state @@ -40,7 +40,7 @@ ADMIN_VERB(secrets, R_NONE, "Secrets", "Abuse harder than you ever have before w var/list/data = list() data["is_debugger"] = is_debugger data["is_funmin"] = is_funmin - data["is_eventmaker"] = is_eventmaker_admin + data["is_eventmaker"] = is_eventmaker_admin // TFF EDIT - Eventmaker return data #define THUNDERDOME_TEMPLATE_FILE "admin_thunderdome.dmm"