From 136bdec88395153ad307b29f0ce1bc95ef21e69f Mon Sep 17 00:00:00 2001 From: Iajret Creature <122297233+Steals-The-PRs@users.noreply.github.com> Date: Mon, 26 Feb 2024 22:36:45 +0300 Subject: [PATCH] [MIRROR] Fix runtime when food processor handles items without reagents (#2125) * Fix runtime when food processor handles items without reagents (#81646) ## About The Pull Request ### Alternate title: "Stop the popsicle stick maximizer."
The popsicle stick maximizer in question ![image](https://github.com/tgstation/tgstation/assets/42909981/29f636f3-6509-4cf9-9093-9fcd0ea5de4f)
So when using the food processor to produce popsicle sticks from logs, it seemed to never actually delete the log, letting you create more and more and more and more and more and etc popsicle sticks. This seemed to be caused by the popsicles not actually having reagents to clear nor copy to, and thus it caused a runtime before it got the opportunity to delete the log.
Runtime ![image](https://github.com/tgstation/tgstation/assets/42909981/bd853870-64e9-4b47-aead-38e6955b7dab)
Adding a check to make sure neither of these are null before proceeding to use them resolves this issue. ## Why It's Good For The Game Less runtimes, less popsicle stick maximizing. Fixes #81644. ## Changelog :cl: fix: Disabled the popsicle stick maximizer. (Producing popsicle sticks actually deletes the input logs.) /:cl: * Fix runtime when food processor handles items without reagents --------- Co-authored-by: NovaBot <154629622+NovaBot13@users.noreply.github.com> Co-authored-by: _0Steven <42909981+00-Steven@users.noreply.github.com> --- code/modules/food_and_drinks/machinery/processor.dm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/code/modules/food_and_drinks/machinery/processor.dm b/code/modules/food_and_drinks/machinery/processor.dm index c3e40300392..0b82a4459be 100644 --- a/code/modules/food_and_drinks/machinery/processor.dm +++ b/code/modules/food_and_drinks/machinery/processor.dm @@ -69,8 +69,9 @@ var/cached_multiplier = (recipe.food_multiplier * rating_amount) for(var/i in 1 to cached_multiplier) var/atom/processed_food = new recipe.output(drop_location()) - processed_food.reagents.clear_reagents() - what.reagents.copy_to(processed_food, what.reagents.total_volume, multiplier = 1 / cached_multiplier) + if(processed_food.reagents && what.reagents) + processed_food.reagents.clear_reagents() + what.reagents.copy_to(processed_food, what.reagents.total_volume, multiplier = 1 / cached_multiplier) if(cached_mats) processed_food.set_custom_materials(cached_mats, 1 / cached_multiplier)