-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embed IPFS node #112
Merged
Merged
Embed IPFS node #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmerrill6
reviewed
Aug 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor comments but other than that LGTM
jsonsivar
reviewed
Aug 18, 2020
jsonsivar
reviewed
Aug 18, 2020
* master: (23 commits) implement ToggleBucketBackup Update docs Clean var name Remove leftover log Refactor temproary hub context helper to return context instead of token since it requires the API sig context embedded into it as well. OS keychain (#115) Update create share API, and add get shared with me files Add user secret and key to config/env and CI. Use helper function for hub connection, use crypto.PubKey for send message input, update tests. Use hub target from global config hotfix: Disable hub token in get public key Fixed tests and bug fix Fix seg fault on mailbox test Test setup for inboxing Use interface for users client so we can test WOrking send example Send message wrapper Fix local and hub ctx colliding. Test mailbox setup in example Fix user client against hub ...
Convert to in process nodes + bump ipfs deps
@dmerrill6 @maurycy since we merged quite a bit of changes to this since the overall approach changed, think it would be a good idea for all of us to review again before going in to master. |
* master: fix(docs): devMode => dev in setup Add GetAPISessionTokens gRPC endpoint (#120)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ch17646]
Fixes #110