Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed IPFS node #112

Merged
merged 23 commits into from
Aug 27, 2020
Merged

Embed IPFS node #112

merged 23 commits into from
Aug 27, 2020

Conversation

maurycy
Copy link
Contributor

@maurycy maurycy commented Aug 14, 2020

[ch17646]

Fixes #110

@maurycy maurycy requested review from dmerrill6 and jsonsivar August 14, 2020 13:01
@maurycy maurycy self-assigned this Aug 14, 2020
@dmerrill6 dmerrill6 marked this pull request as ready for review August 14, 2020 14:05
Copy link
Contributor

@dmerrill6 dmerrill6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments but other than that LGTM

core/ipfs/node/node.go Outdated Show resolved Hide resolved
core/ipfs/node/node.go Outdated Show resolved Hide resolved
maurycy and others added 10 commits August 21, 2020 15:56
* master: (23 commits)
  implement ToggleBucketBackup
  Update docs
  Clean var name
  Remove leftover log
  Refactor temproary hub context helper to return context instead of token since it requires the API sig context embedded into it as well.
  OS keychain (#115)
  Update create share API, and add get shared with me files
  Add user secret and key to config/env and CI.
  Use helper function for hub connection, use crypto.PubKey for send message input, update tests.
  Use hub target from global config
  hotfix: Disable hub token in get public key
  Fixed tests and bug fix
  Fix seg fault on mailbox test
  Test setup for inboxing
  Use interface for users client so we can test
  WOrking send example
  Send message wrapper
  Fix local and hub ctx colliding.
  Test mailbox setup in example
  Fix user client against hub
  ...
Convert to in process nodes + bump ipfs deps
@jsonsivar
Copy link
Contributor

@dmerrill6 @maurycy since we merged quite a bit of changes to this since the overall approach changed, think it would be a good idea for all of us to review again before going in to master.

* master:
  fix(docs): devMode => dev in setup
  Add GetAPISessionTokens gRPC endpoint (#120)
* master:
  Hotfix: use cfg values for txl hub key and secret instead of directly from env
  Vault: Clientside implementation (#121)
  Use string for nextoffset, add new notifications clear, update accept/reject share endpoint names
  Add unimplemented method to get recently shared with (#125)
@maurycy maurycy merged commit c1849b7 into master Aug 27, 2020
@maurycy maurycy deleted the feature/ipfs-node branch August 27, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.0.12 Linux x86_64 build does not have the -ipfsaddr flag
3 participants