Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go client tries to unmarshal JSON response from all error codes #110

Closed
matthewelwell opened this issue Jan 18, 2024 · 0 comments · Fixed by #139
Closed

Go client tries to unmarshal JSON response from all error codes #110

matthewelwell opened this issue Jan 18, 2024 · 0 comments · Fixed by #139

Comments

@matthewelwell
Copy link
Contributor

As per this line here, the Go client attempts to unmarshal a JSON body from all responses. This fails when it receives e.g. a 502 or 503, we should attempt to handle this correctly so that the client can correctly fall back to its default values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: replace internal http client with resty Flagsmith/flagsmith-go-client
1 participant
@matthewelwell