Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update InfluxDB #120

Closed
dabeeeenster opened this issue Jan 5, 2023 · 8 comments
Closed

Update InfluxDB #120

dabeeeenster opened this issue Jan 5, 2023 · 8 comments
Assignees

Comments

@dabeeeenster
Copy link
Contributor

dabeeeenster commented Jan 5, 2023

Had a report from a customer that the current version of Influx isn't compatiable with latest version of Kubernetes. Not sure quite how to reproduce however. Can we try and run the chart with Influx enabled and see what happens?

@plumdog
Copy link
Contributor

plumdog commented Jan 5, 2023

@dabeeeenster it looks to me like the version of the InfluxDB chart we are using doesn't support k8s>=1.22.

We are using influxdb2 chart version 2.0.0 (see https://github.com/Flagsmith/flagsmith-charts/pull/50/files#diff-b47ee2ff78b27e1238ffafd64c2155ce5d860904435f39890491876c52cda9f9R12-R16), but chart version 2.0.9 is where they introduced support for k8s >= 1.22.

I think this line https://github.com/Flagsmith/flagsmith-charts/pull/50/files#diff-b47ee2ff78b27e1238ffafd64c2155ce5d860904435f39890491876c52cda9f9R14 is the interesting one. The linked issue influxdata/helm-charts#350 is closed, but looks more like a workaround than a "fix in version X" resolution.

I shall:

  • try installing the chart on k8s 1.22 with influxdb enabled and verify it fails
  • update the influxdb chart to the latest version and see if it appears to work
    • if so, that'll be my PR
    • if not, I'll dig into the influxdb issue and see what I need to do to workaround it

@dabeeeenster
Copy link
Contributor Author

Additional info from someone who has run into this:

I was doing some POC work with minikube and fluxcd in my local machine and I found that the InfluxDB2 reference in the helm chart calls on pod disruption budget. It looks like in Kubernetes 1.25 they removed the old name (policy/v1beta1 referenced here). I think in your helm chart it may be a case of simply changing the influxdb version from what you have to a newer one and it should resolve the issue.

@Starefossen
Copy link

Same! Also, please update the Postgres chart as well 🙏🏻

@dabeeeenster
Copy link
Contributor Author

Same! Also, please update the Postgres chart as well 🙏🏻

Hey @Starefossen - what issue/requirement do you have for an updated Postgres chart?

@Starefossen
Copy link

@dabeeeenster
Copy link
Contributor Author

Ah understood - thanks! Added here: #121

@dabeeeenster
Copy link
Contributor Author

Closing on account of #126

@khvn26
Copy link
Member

khvn26 commented Apr 18, 2023

Actually fixed in #132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants