From f68d13f60062c06e6444d28c9dee35f873654a61 Mon Sep 17 00:00:00 2001 From: Jeremiah Senkpiel Date: Wed, 5 Jun 2019 16:47:25 -0700 Subject: [PATCH] references: add offset to pull Refs: https://github.com/Fishrock123/bob/issues/23 --- reference-buffered-transform.js | 2 +- reference-passthrough.js | 4 ++-- reference-sink.js | 2 +- reference-source.js | 3 ++- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/reference-buffered-transform.js b/reference-buffered-transform.js index bcfe09a..50ab837 100644 --- a/reference-buffered-transform.js +++ b/reference-buffered-transform.js @@ -55,7 +55,7 @@ class BufferedTransform { } } - pull (error, buffer) { + pull (error, buffer /*, offset */) { if (this._bytes === 0) { return this.source.pull(error, buffer) } diff --git a/reference-passthrough.js b/reference-passthrough.js index 2546b42..6887ef2 100644 --- a/reference-passthrough.js +++ b/reference-passthrough.js @@ -21,8 +21,8 @@ class PassThrough { this.sink.next(status, error, buffer, bytes) } - pull (error, buffer) { - this.source.pull(error, buffer) + pull (error, buffer, offset) { + this.source.pull(error, buffer, offset) } } diff --git a/reference-sink.js b/reference-sink.js index abd87fb..5f5a618 100644 --- a/reference-sink.js +++ b/reference-sink.js @@ -25,7 +25,7 @@ class Sink { // sink handles buffer allocation const buffer = new Buffer(0) - this.source.pull(null, buffer) + this.source.pull(null, buffer, 0) } next (status, error, buffer, bytes) { diff --git a/reference-source.js b/reference-source.js index a9f76f1..e8d3172 100644 --- a/reference-source.js +++ b/reference-source.js @@ -12,9 +12,10 @@ class Source { this.sink = sink } - pull (error, buffer) { + pull (error, buffer, offset) { // error MUST be null or an error // buffer MUST be a Buffer + // if offset exists, use it if possible if (error || sourceError) { return this.sink.next(status_type.error, error) }