Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITypedElement.VisitAll: check also the definition property #2597

Closed
marcovisserFurore opened this issue Sep 21, 2023 · 1 comment
Closed

Comments

@marcovisserFurore
Copy link
Member

Describe the bug
In Firely Server, for the patch operation, we create a PartToElementAdapter (see https://github.com/FirelyTeam/Vonk/blob/0b352a37b8d717b4c590622dc5d89347670e5c54/src/Vonk.Core/ElementModel/FhirPatchedElement.cs#L176) with the field to patch. In case of a non-existing field for the resource type to be patched, when getting the definition of the element, we get an exception. So, as part of the prevalidation for the patch operation, we would like to check that both the value but also the definition of all the PartToElementAdapter are valid.

Version used:

  • Version: 5.3.0

Additional context
Suggested PR:
Add an access to the Definition property when visiting all descendants of a ITypedElement in order to detect element with an invalid definition . See #2594

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants