-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align Error messages from validator and parser #2580
Labels
breaking change
This issue/commit causes a breaking change, and requires a major version upgrade
enhancement
Comments
We should make sure the property validator and the parser should not double errors. |
Maybe not run attribute validation when an element has reported a parse error. |
There is a flag on the serializer for that already. |
ewoutkramer
added
the
breaking change
This issue/commit causes a breaking change, and requires a major version upgrade
label
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
This issue/commit causes a breaking change, and requires a major version upgrade
enhancement
Is your feature request related to a problem? Please describe.
There are some errors that the parser is able to check that the validator also checks, these should really be aligned so that they use the same error code, and hopefully return the same location. (so they can be de-duplicated when needed)
e.g.
Describe the solution you'd like
PVAL116
and6007
are the same error, shouldn't they be the same coding?Alternatively provide another routine to be able to cross reference the codes, and or locations. The validator looks like it doesn't use the short form of the path where it doesn't consider every item an array, and only include the positional accessors when it is a collection.
Describe alternatives you've considered
I'm contemplating writing a routine to manually do this processing.
The text was updated successfully, but these errors were encountered: