Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Moq with NSubstitute #2572

Closed
mmsmits opened this issue Aug 10, 2023 · 1 comment · Fixed by #2757
Closed

Replace Moq with NSubstitute #2572

mmsmits opened this issue Aug 10, 2023 · 1 comment · Fixed by #2757
Assignees
@Kasdejong
Labels
dependencies Pull requests that update a dependency file

Comments

@mmsmits
Copy link
Member

mmsmits commented Aug 10, 2023

Moq is misusing the source code analyzers as of version 4.20:

https://github.com/moq/moq/pull/1363

We should replace it with an alternative, for example NSubstitude
@mmsmits mmsmits added the dependencies Pull requests that update a dependency file label Aug 10, 2023
@baseTwo
Copy link

baseTwo commented Jan 18, 2024

I second using NSubstitude

@Kasdejong Kasdejong self-assigned this Apr 3, 2024
@Kasdejong Kasdejong changed the title Replace Moq with NSubstitude Replace Moq with NSubstitute Apr 3, 2024
@Kasdejong Kasdejong mentioned this issue Apr 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kasdejong Kasdejong

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replaced moq with NSubstitute FirelyTeam/firely-net-sdk
3 participants
@baseTwo @mmsmits @Kasdejong