Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of Poco Instant #2532

Closed
marcovisserFurore opened this issue Jul 13, 2023 · 1 comment
Closed

Improve performance of Poco Instant #2532

marcovisserFurore opened this issue Jul 13, 2023 · 1 comment

Comments

@marcovisserFurore
Copy link
Member

The POCO date types have their ObjectValue set to string, and will parse the string into a DateTimeOffset every time a something is "done" with the type (e.g. comparing, getting Utc dates, etc). This causes performance issues in the CQL engine, so we should try to cache the conversion from string to DateTimeOffset (invalidating it when the ObjectValue/Value is changed).

See for inspiration PR #2529 where it is already implemented for FhirDateTime.

@ewoutkramer
Copy link
Member

The existing Instant datatype is already stored as a DateTimeOffset internally, so we do not have to cache or speed things up for this datatype. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants