Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot generator merge does not handle the new R5 ElementDefinition properties mustHaveValue and valueAlternatives #2513

Closed
Rob5045 opened this issue Jun 28, 2023 · 3 comments · Fixed by #2522
Assignees
Labels

Comments

@Rob5045
Copy link
Contributor

Rob5045 commented Jun 28, 2023

In R5, ElementDefinition now contains 2 new properties:

  • mustHaveValue
  • valueAlternatives

When using the SDK 5.2 in Forge and opening a profile where these properties are set in the differential, these elements do not get merged by the snapshot generator.

Looking at the SnapshotGenerator method ElementDefnMerger, these new properties are not processed.

@marcovisserFurore
Copy link
Member

Hi @Rob5045, these properties are new in R5 and are not used by the SnapshotGenerator yet. I think it is a easy fix. Should we do it, or do we get a PR from you?

@Rob5045
Copy link
Contributor Author

Rob5045 commented Jul 4, 2023

Hi @marcovisserFurore , because these are R5 only additions, something special needs to be done to avoid duplicating code. That is an architectural problem that I think you can better solve.

@marcovisserFurore
Copy link
Member

Great Rob, then we will take care of it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants