Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO in the code base #2

Open
robsonsilv4 opened this issue Jan 4, 2024 · 1 comment
Open

TODO in the code base #2

robsonsilv4 opened this issue Jan 4, 2024 · 1 comment

Comments

@robsonsilv4
Copy link

Hello @Firefnix , working on PR #1, I saw some TODO comments in the code. Do you remember what's needs to be updated?

@Firefnix
Copy link
Owner

Hi, @robsonsilv4, sadly I don't remember what needed to be done on those.

  • A possibility is that by "change" I meant override, and if so, it looks like it's already done and I simply didn't update the comments
  • Otherwise, I probably noticed a widget where the current colors were not matching what I wanted (in that case, I should've documented it with the TODO 😅)

Anyway, thank you for your PR! I've started reviewing it and it I'm liking your improvement proposals so far! I'll approve it after reviewing it completely and testing the new version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants