Skip to content

Latest commit

 

History

History
88 lines (54 loc) · 3.54 KB

CONTRIBUTING.md

File metadata and controls

88 lines (54 loc) · 3.54 KB
Raw

Contribution Guidelines

First off, thanks for taking the time to contribute! 👍

I just have a question

You can launch a quick question on the #acpaas-ui slack channel. If you're not yet a member of the DigAnt Café slack community, you can easily join here.

For something that requires longer discussion it may be better to book an issue.

How do I report bugs / ask features?

Please book a GitHub issue.

What should I know to get started?

This widget is part of the ACPaaS UI platform. For more info about Smart Widgets, check the documentation hub.

Before contributing code, you should be aware of the following:

  • The look and feel should match the Antwerp Core Branding guidelines.
  • The architecture consists of a separate front-end and back-end package. The back-end is a so-called Backend-For-Frontend (BFF). The architecture should conform to the SA2020 guidelines.
  • There may be multiple independent front-ends and back-ends for the different technologies that Digipolis supports. All of these should implement the same BFF API. The set of supported technologies is described in the DAAS standard.
  • All code should conform to the Angular style guide, as well as the ACPaaS UI guidelines.

How can I contribute code?

Code layout

  • ./projects/smart-table contains the widget source
  • ./projects/example contains the example app's frontend
  • ./projects/example-api contains the example app's BFF API

Building and Testing

> npm install

Commands:

  • Start the example app

    > npm start

This project was generated with Angular CLI.

It is based on the instructions in this article.

Initial development was done by Vanessa De Middelaer. Angular 6+ compatibility and packaging was done by Joeri Sebrechts.

Submitting Changes

Please send us your changes as a GitHub pull request.

In order for us to be able to accept your pull request without remarks, please do these things:

  • Follow the above style guides.
  • Please update the readme documentation and example app along with the code.
  • Make sure all the tests pass.
  • Provide a clear description on the pull request of what was changed
  • Link to a relevant issue. Feel free to create one if none exists.

If possible, do provide meaningful and clean commit messages. A good commit message completes the sentence "When committed this will …"

Publishing

Only the ACPaaS UI team publishes new packages. Contact us if you need a new release published.

Follow these steps to publish a new version of the package. You must be a member of the @acpaas-ui-widgets organization on GitHub.

  1. Increment the version in projects/smart-table/package.json

  2. Build the application

    > npm run build

  3. Log in to the npmjs registry

    > npm login

  4. Publish the package

    > npm publish dist/smart-table

    It will be built automatically prior to publishing.