Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update folsom #49

Closed
scohen opened this issue Dec 3, 2015 · 9 comments
Closed

Update folsom #49

scohen opened this issue Dec 3, 2015 · 9 comments
Assignees

Comments

@scohen
Copy link

scohen commented Dec 3, 2015

The version of folsom that this project uses is unmaintained; consider switching to
https://github.com/folsom-project

@tolbrino
Copy link
Contributor

tolbrino commented Dec 3, 2015

Thanks for the heads up. Do you have a pointer to an announcement? The boundary repository doesn't state anything in respect to that.

@scohen
Copy link
Author

scohen commented Dec 3, 2015

I stumbled upon it in the boundary repo; all issues have the same comment.

boundary/folsom#101

@tolbrino
Copy link
Contributor

tolbrino commented Dec 4, 2015

You're right, I should have looked better. We'll just wait until the tags have been migrated.

@okeuday
Copy link

okeuday commented Dec 29, 2015

I noticed the new folsom branch breaks on rebar2 due to a dependency forcing rebar3 usage. Might be good to clear up that problem first.

@okeuday
Copy link

okeuday commented Dec 29, 2015

I might be wrong about this and remembering some other project dependency, either way it would be good to make sure the rebar support is clear.

@tolbrino
Copy link
Contributor

@okeuday Could you elaborate on this, or even better provide a test case? I tried various combinations of rebar, exometer_core and folsom and couldn't find an issue.

@okeuday
Copy link

okeuday commented Dec 29, 2015

@tolbrino Sorry, I don't see this as a current issue based on my own checking. If this was an issue with exometer repos or folsom repos, it was fixed, but I probably confused this with a different repo that was related to metrics.

@tolbrino
Copy link
Contributor

@okeuday Got it. I'll keep that in mind in case we run into a similar issue.

@tolbrino
Copy link
Contributor

Closing this issue, since we merged the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants