Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes, but not always, clipboard contents are appended to rather than replaced #19

Open
psycotica0 opened this issue Nov 29, 2023 · 6 comments
Labels
👆 good first issue Good for newcomers 👾 bug Something isn't working 💯 enhancement New feature or request

Comments

@psycotica0
Copy link

Bug Report

Current Behavior
I don't know when it starts or when it stops. I just tried a bunch, both with the keybinding, and searching, and arrow keys, and clicking emoji with the mouse, and just kept picking some, then pasting, then copying something else, then pasting, and it mostly worked the way I expected which is that the clipboard's value is just the one emoji I picked.

But eventually it will switch to instead adding the emoji onto the end of the clipboard, even if there's text in there, and then I'll end up pasting whatever that was and then having to delete most of it to get down to just the emoji on the end I want. I haven't found the pattern yet...

Expected behavior/code
I expect that after I've picked an emoji my clipboard will contain only that emoji and its previous contents will be lost.

Environment

  • emoji-copy version(s): 12
  • paste-on-select: false
@FelipeFTN FelipeFTN added 👾 bug Something isn't working 💯 enhancement New feature or request 👆 good first issue Good for newcomers labels Nov 29, 2023
@FelipeFTN
Copy link
Owner

Hey @psycotica0!! Thank you for your help finding these things! 😄 You're doing such a nice job!
Maybe cleaning the clipboard before copying a new emoji into it should work, don't you think?
This could be an interesting addition to the code, hope this works.
I will be testing it soon, the copy-paste functions must be polished, and you are doing a great work by finding it! Thank you a lot!! 🥇

@psycotica0
Copy link
Author

psycotica0 commented Nov 29, 2023

Interesting... I've been using Emoji Selector for years and never remember it having this problem, so I thought this may be a new problem. But maybe not? Did the clipboard handling code change at all in Gnome 44/45?

@FelipeFTN
Copy link
Owner

I don't think I changed anything too much problematic while migrating this functionality, but it's always possible.
I think the clipboard handling didn't change in anything but libraries imports and stuff.
Anyways, I will take a look at this! Thanks for the suggestion!

@NatVIII
Copy link
Contributor

NatVIII commented Dec 2, 2023

I don't want to be dismissive but is it possible you may have been accidentally right clicking on emojis? What you're describing is the functionality for right clicking emojis, perhaps you have a trackpad that can click the wrong mouse button sometimes? Please see if it can be replicated though, if you're definitely clicking the lmb and it's still happening and provable then it's a bit of an issue.

@psycotica0
Copy link
Author

psycotica0 commented Dec 2, 2023 via email

Repository owner deleted a comment Jan 1, 2024
@tom-ricci
Copy link

I'm noticing this on Gnome 42. It seems to be consistent actually, whenever I navigate to an emoji via the keyboard, it will append. If I click on the emoji with the mouse, it works as intended.

I also notice that the emoji picker only automatically disappears when using the mouse to select emoji. Not sure if this is intended behavior, but my first thought was that it was related to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👆 good first issue Good for newcomers 👾 bug Something isn't working 💯 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants