-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix using Term
on nightly - julia 1.12
#245
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #245 +/- ##
==========================================
- Coverage 87.29% 87.27% -0.03%
==========================================
Files 48 48
Lines 2873 2899 +26
==========================================
+ Hits 2508 2530 +22
- Misses 365 369 +4 ☔ View full report in Codecov by Sentry. |
@FedeClaudi, bump ? Would it make sense to add myself as a editor of this repo so that I can merge pull requests (mostly maintenance such as this one) ? |
Hey, sure let me add you to the repo! |
Thanks ! Any objection for merging this PR ? |
Fix #246, and fix testsuite on
v"1.6" ≤ VERSION ≤ v"1.12"
.Fix #237, by skipping writing files on
CI
orPKGEVAL
.Also,
[compat]
bounds per this PSA;master
: this branch should always be tested !;nightly
and upcoming1.11
.@FedeClaudi, a version bump after this merge would be appreciated in order to re-enable
NanoSoldier - PkgEval
checks.Needed in order to allow
UnicodePlots
testsuite to run onnightly
.