Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix using Term on nightly - julia 1.12 #245

Merged
merged 9 commits into from
Apr 25, 2024
Merged

Conversation

t-bltg
Copy link
Collaborator

@t-bltg t-bltg commented Mar 26, 2024

Fix #246, and fix testsuite on v"1.6" ≤ VERSION ≤ v"1.12".
Fix #237, by skipping writing files on CI or PKGEVAL.

Also,

  • add stdlib [compat] bounds per this PSA;
  • restore CI on master: this branch should always be tested !;
  • cancel builds in progress on a PR to spare CI credits;
  • update CI jobs, test nightly and upcoming 1.11.

@FedeClaudi, a version bump after this merge would be appreciated in order to re-enable NanoSoldier - PkgEval checks.

Needed in order to allow UnicodePlots testsuite to run on nightly.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.27%. Comparing base (a9e1af3) to head (440ce2c).
Report is 28 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
- Coverage   87.29%   87.27%   -0.03%     
==========================================
  Files          48       48              
  Lines        2873     2899      +26     
==========================================
+ Hits         2508     2530      +22     
- Misses        365      369       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t-bltg
Copy link
Collaborator Author

t-bltg commented Apr 18, 2024

@FedeClaudi, bump ?

Would it make sense to add myself as a editor of this repo so that I can merge pull requests (mostly maintenance such as this one) ?

@FedeClaudi
Copy link
Owner

Hey, sure let me add you to the repo!

@t-bltg
Copy link
Collaborator Author

t-bltg commented Apr 25, 2024

Thanks !

Any objection for merging this PR ?

@t-bltg t-bltg merged commit eaf337c into FedeClaudi:master Apr 25, 2024
11 checks passed
@t-bltg t-bltg deleted the fix_1.12 branch April 25, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

using Term broken on nightly (1.12) Don't write inside of the package directory
2 participants