Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't write inside of the package directory #237

Closed
maleadt opened this issue Jan 4, 2024 · 1 comment · Fixed by #245
Closed

Don't write inside of the package directory #237

maleadt opened this issue Jan 4, 2024 · 1 comment · Fixed by #245

Comments

@maleadt
Copy link

maleadt commented Jan 4, 2024

During testing of this package, output is being written to a directory inside of the package:

# save expressions to file (for later comparisons)
for (i, e) in enumerate(expressions)
tofile(string(Dendogram(e)), "./txtfiles/dendo_expr_$i.txt")
tofile(string(Tree(e)), "./txtfiles/tree_expr_$i.txt")
tofile(sprint(expressiontree, e), "./txtfiles/exptree_expr_$i.txt")
end

This is not OK, as packages can be installed in a read-only environment. As a result, this package fails testing on PkgEval.
For the time being, I'll blacklist testing of this package, but if this gets fixed feel free to ping me or open a PR on PkgEval.jl to resume testing.

maleadt added a commit to JuliaCI/PkgEval.jl that referenced this issue Jan 4, 2024
@FedeClaudi
Copy link
Owner

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants