Proposed patch to issue #24 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schemas with additional properties were not properly serialized.
|
Sounds good. Would it be possible to have a simple unit test for this? :-) |
|
Of course |
|
Here there are, tell me how you see it |
|
I assume closing was accidental, reopening. |
|
Looks good & I will merge. One minor comment for future: could you try not to reformat existing classes? It's probably an IDE setting or such; just prefer not cosmetic change as they increase diffs and can sometimes hide actual functional changes. |
cowtowncoder
added a commit
that referenced
this pull request
Oct 15, 2013
Proposed patch to issue #24 -- thanks!
|
Ok, sorry for the refactoring. |
|
No prob -- thank you for the fix! |
|
yw, thank you for this useful project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #24