Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jackson JSR353 library is using wrong module name for javax json api #7

Closed
moquinr opened this issue Jan 8, 2021 · 7 comments
Closed
Labels
jsr-353 Issue related to JSR-353/JSONP datatype module
Milestone

Comments

@moquinr
Copy link

moquinr commented Jan 8, 2021

In the jsr353 module, the javax json api module require statement is using the wrong module name, resulting in this error:

java.lang.module.FindException: Module javax.json.api not found, required by com.fasterxml.jackson.datatype.jsr353

The "correct" name (in quotes because there is no consistency in the jakarta projects on how they named the javax modules :( ) is java.json.

So it should be

requires java.json;

rather than

requires javax.json.api;
@cowtowncoder
Copy link
Member

@moquinr sounds reasonable -- I don't use module system in general, nor this module specifically, so I rely on others to find out these issues.

@GedMarc any comments? Is this yet another thing that has changed over time, or did I just guess wrong module name originally? But most importantly, do you agree with the change proposed?

@moquinr
Copy link
Author

moquinr commented Jan 8, 2021

Your guess would have been correct if it was using the automated module name. Honestly, I didn't think the jar would have a module descriptor in it, so I'm guessing you probably didn't either. :)

@cowtowncoder
Copy link
Member

@moquinr no, and I think there may also have been complications about multiple competing api jars with possibly conflicting settings (often seems to happen with jcp/jsr jars). But not saying there necessarily was any solid reasoning involved :)

@cowtowncoder cowtowncoder modified the milestones: 2, 2.12.1 Jan 8, 2021
@cowtowncoder
Copy link
Member

Looking at jar itself, yes, declared module name is "java.json" so making the change as suggested (confirmed by javap on module-info.class).

@GedMarc
Copy link

GedMarc commented Jan 8, 2021

Naw i have no idea on this, i do see java.json though

image

@moquinr
Copy link
Author

moquinr commented Jan 11, 2021

Thanks guys!

@cowtowncoder
Copy link
Member

Released in 2.12.1.

@cowtowncoder cowtowncoder added the jsr-353 Issue related to JSR-353/JSONP datatype module label Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jsr-353 Issue related to JSR-353/JSONP datatype module
Projects
None yet
Development

No branches or pull requests

3 participants