[Avro] Fix unit test for untyped map schema generation. #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of `InvalidDefinitionException`. Reason in 2.13 in that `ToEmptyObjectSerializer` is used to serialize `java.util.Map` which calls `visitor.expectObjectFormat(typeHint)` and thus different exception is thrown at the end and when schema is requested from mapper.
|
Thank you for digging into this! Ideally, I think, we should try to avoid exposing non-Jackson Not sure if exception 2.12 uses is optimal, but it seems better than I'll merge this first to stop failing CI and see if I can find time to further improve handling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 2.13,
UnsupportedOperationExceptionis thrown instead ofInvalidDefinitionException.Fixes #281