This repository has been archived by the owner on Jan 22, 2019. It is now read-only.
Fix UTF8Writer when used in same thread #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to #70, UTF8Writer should not reuse the byte array when it is used in the same thread.
|
@cowtowncoder Hi! Sorry to be insistent, but we'd be happy if you can have a look to this pull request when you have time :) |
|
@tlrx Thank you for the ping -- I just came back from 3 week vacation, hence the delay! Will review this today. |
cowtowncoder
added a commit
that referenced
this pull request
Jan 10, 2017
|
@cowtowncoder Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #70,
UTF8Writershould not reuse the recycled byte array when it is used in the same thread.In the current state, I'm wondering if the usage of
_bufferRecyclerand_bufferHolderis a real performance gain. Would it make sense to just remove them (ie always get anew byte[DEFAULT_BUFFER_SIZE])?