Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Module as JacksonModule in 3.0 (to avoid overlap with java.lang.Module) #3037

Closed
cowtowncoder opened this issue Jan 31, 2021 · 1 comment
Closed

Rename Module as JacksonModule in 3.0 (to avoid overlap with java.lang.Module) #3037

cowtowncoder opened this issue Jan 31, 2021 · 1 comment
Labels
3.x Issues to be only tackled for Jackson 3.x, not 2.x
Milestone
3.0.0

Comments

@cowtowncoder
Copy link
Member

At the time, com.fasterxml.jackson.databind.Module was not problematic, but with Java 9 and later there is now Module in java.lang -- requiring explicit package name for Jackson's Module, everywhere.
While this is how it has to be for 2.x, let's rename base abstraction in 3.0.
@cowtowncoder cowtowncoder added the 3.x Issues to be only tackled for Jackson 3.x, not 2.x label Jan 31, 2021
@cowtowncoder cowtowncoder added this to the 3.0.0 milestone Feb 3, 2021
cowtowncoder added a commit that referenced this issue Feb 3, 2021
@cowtowncoder
One more fix wrt #3037
4064034
@cowtowncoder
Copy link
Member Author

All went well until Scala module, which apparently has type JacksonModule.scala.
Will need to file a separate issue there.

@cowtowncoder cowtowncoder mentioned this issue Feb 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.x Issues to be only tackled for Jackson 3.x, not 2.x
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@cowtowncoder