Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObjectMapper. getRegisteredModuleIds() throws NPE if no modules registered #2374

Merged
merged 1 commit into from
Jul 2, 2019

Conversation

nstdio
Copy link
Contributor

@nstdio nstdio commented Jun 29, 2019

#getRegisteredModuleIds() does not throws NullPointerException when there is no registered modules, now it returns a empty unmodifiable set.

new ObjectMapper().getRegisteredModuleIds() // throws NPE

@cowtowncoder
Copy link
Member

Thank you for reporting this, providing patch! It may take me a while to get this merged in (due to number of issues, my vacation), but I will get it done eventually. :)

@cowtowncoder
Copy link
Member

Actually due to simplicity of the fix, I'll do it quickly, instead of eventually. :)

@cowtowncoder cowtowncoder merged commit a18e2c0 into FasterXML:2.10 Jul 2, 2019
@cowtowncoder cowtowncoder changed the title Return empty unmodifiable set when no registered modules types. ObjectMapper. getRegisteredModuleIds() throws NPE if no modules registered Jul 2, 2019
@cowtowncoder cowtowncoder modified the milestones: 2.9,0.pr4, 2.9.10 Jul 2, 2019
cowtowncoder added a commit that referenced this pull request Jul 2, 2019
@nstdio nstdio deleted the registered_modules branch July 2, 2019 16:24
@nstdio
Copy link
Contributor Author

nstdio commented Jul 2, 2019

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants