-
-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow use of java.nio.file.Path
as parser source, generator target (for Jackson databind#2013)
#680
Conversation
cacc398
to
7795579
Compare
After getting the permission to add some Unit tests those tests have been added. Have you noticed that the Unit tests in this project are still JUnit 3? |
7795579
to
8236e2c
Compare
And adding base tests for all createGenerator(..) and createParser(..) methods.
8236e2c
to
b1d56b7
Compare
Junit dependency itself is to 4.x isn't it? As to test style, if it ain't broke... if there are specific improvement ideas those are always good to suggest of course; and if there are questions of why certain things are certain way you can add questions here or ask on gitter chat etc. |
java.nio.file.Path
as parser source, generator target (for Jackson databind#2013)
Merged; big thank you for increased test coverage! Although methods are quite trivial, there have been cases where even simplest implementations have had some odd edge cases (occasionally silly things like infinite recursion due to refactoring etc). |
Quick note: missed the fact that |
Good to know. I'll look at it the next two weeks. |
@sdoeringNew no need; I added the methods :) |
Is there no need to write Unit tests? The changed
TextualTSFactory
has barely coverage.