From 2d3c0a56f9a2aa83012a8e689b958e4652b19428 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jo=C3=A3o=20Pereira=20Rodrigues?= <j.rodrigues@farfetch.com>
Date: Wed, 13 Mar 2024 15:58:56 +0000
Subject: [PATCH] fix: solving discussions

---
 samples/KafkaFlow.Sample/README.md            |  8 ++++
 .../KafkaFlow.Admin.Dashboard.csproj          | 39 +++----------------
 2 files changed, 13 insertions(+), 34 deletions(-)

diff --git a/samples/KafkaFlow.Sample/README.md b/samples/KafkaFlow.Sample/README.md
index 1439c5195..bb41ee7d9 100644
--- a/samples/KafkaFlow.Sample/README.md
+++ b/samples/KafkaFlow.Sample/README.md
@@ -19,6 +19,14 @@ Position the terminal in that folder and run the following command.
 docker-compose up -d
 ```
 
+### Build Dashboard UI
+
+Using your terminal of choice, navigate to `kafkaflow\src\KafkaFlow.Admin.Dashboard\ClientApp` folder and run the following command:
+
+```bash
+ng build
+```
+
 ### Run the Sample
 
 Using your terminal of choice, start the sample for the sample folder.
diff --git a/src/KafkaFlow.Admin.Dashboard/KafkaFlow.Admin.Dashboard.csproj b/src/KafkaFlow.Admin.Dashboard/KafkaFlow.Admin.Dashboard.csproj
index 116e5de93..ae071e278 100644
--- a/src/KafkaFlow.Admin.Dashboard/KafkaFlow.Admin.Dashboard.csproj
+++ b/src/KafkaFlow.Admin.Dashboard/KafkaFlow.Admin.Dashboard.csproj
@@ -21,52 +21,23 @@
     <EmbeddedResource Remove="ClientApp\node_modules\**" />
     <Content Remove="ClientApp\node_modules\**" />
   </ItemGroup>
-
-  <PropertyGroup>
-    <SpaRoot>ClientApp\</SpaRoot>
-    <DefaultItemExcludes>$(DefaultItemExcludes);$(SpaRoot)node_modules\**</DefaultItemExcludes>
-    <AssemblyName>KafkaFlow.Admin.Dashboard</AssemblyName>
-  </PropertyGroup>
-
-  <Target Name="EnsureNode">
-    <Exec WorkingDirectory="$(SpaRoot)" Command="node --version" ContinueOnError="true">
-      <Output TaskParameter="ExitCode" PropertyName="ErrorCode" />
-    </Exec>
-    <Error Condition="'$(ErrorCode)' != '0'" Text="Node.js is required to build and run this project. To continue, please install Node.js from https://nodejs.org/, and then restart your command prompt or IDE." />
-  </Target>
-
-  <Target Name="DebugRunNgBuild" BeforeTargets="Build" Condition=" '$(Configuration)' == 'Debug' ">
-    <CallTarget Targets="EnsureNode" />
-    <Message Importance="high" Text="Install packages..." />
-    <Exec WorkingDirectory="$(SpaRoot)" Command="npm install" />
-    <Message Importance="high" Text="Performing ng build for prd build..." />
-    <Exec WorkingDirectory="$(SpaRoot)" Command="npm run build" />
-  </Target>
-
-  <Target Name="ReleaseRunNgBuild" BeforeTargets="Build" Condition=" '$(Configuration)' == 'Release' ">
-    <CallTarget Targets="EnsureNode" />
-    <Message Importance="high" Text="Install packages..." />
-    <Exec WorkingDirectory="$(SpaRoot)" Command="npm install" />
-    <Message Importance="high" Text="Performing ng build for prd build..." />
-    <Exec WorkingDirectory="$(SpaRoot)" Command="npm run build:prod" />
-  </Target>
-
+  
   <ItemGroup>
     <PackageReference Include="Microsoft.Extensions.FileProviders.Embedded" Version="6.0.25" />
     <PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
   </ItemGroup>
-
+  
   <ItemGroup>
     <Compile Remove="ClientApp\node_modules\**" />
   </ItemGroup>
-
+  
   <ItemGroup>
     <Compile Remove="ClientApp\node_modules\**" />
   </ItemGroup>
-
+  
   <ItemGroup>
     <ProjectReference Include="..\KafkaFlow.Admin\KafkaFlow.Admin.csproj" />
     <ProjectReference Include="..\KafkaFlow\KafkaFlow.csproj" />
   </ItemGroup>
-
+  
 </Project>