Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Newtonsoft dependency #150

Open
dtkujawski opened this issue Mar 15, 2024 · 1 comment
Open

Remove Newtonsoft dependency #150

dtkujawski opened this issue Mar 15, 2024 · 1 comment
Labels
enhancement New feature or request low priority Low priority issue

Comments

@dtkujawski
Copy link

dtkujawski commented Mar 15, 2024

Describe the solution you'd like

While KafkaFlow allows use of either CoreJson or Newtonsoft through KafkaFlow.Serializer.JsonCore and KafkaFlow.Serializer.Newtonsoft, KafkaFlow-Retry (the durable code) is hard-coded to use Newtonsoft directly.

For projects that want to reduce unnecessary dependencies and are using CoreJson, this dependency can't be avoided.

It would be nice if the Durable retry code used the same serializer/deserializer as the main KafkaFlow (ISerializer & IDeserializer)

Are you able to help bring it to life and contribute with a Pull Request?

No

@dtkujawski dtkujawski added the enhancement New feature or request label Mar 15, 2024
@luispfgarces luispfgarces added the low priority Low priority issue label May 27, 2024
@luispfgarces
Copy link
Contributor

Hi @dtkujawski,

Thank you for reaching out and for your suggestion. We have discussed your request internally and we'll assess the feasibility of it as soon as we find the time to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority Low priority issue
Projects
None yet
Development

No branches or pull requests

2 participants