Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(hopper_v4): add forward/health reward and ctrl cost to step info #602

Closed
wants to merge 1 commit into from
Closed

refactor(hopper_v4): add forward/health reward and ctrl cost to step info #602

wants to merge 1 commit into from

Conversation

rickstaa
Copy link

Description

This pull request adds the Forward and Health reward and control cost to the info dictionary that is returned by the step method of the hopper_v4 environment.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@rickstaa rickstaa changed the title refactor(hopper_v4): add forward/ctrl and health reward to step info refactor(hopper_v4): add forward/health reward and ctrl cost to step info Jul 12, 2023
@rickstaa
refactor(hopper_v4): add forward/health reward and ctrl cost to step …
62a134a 
…info

This commit adds the 'reward_forward', 'reward_ctrl' and 'reward_survive' to the
info dict that the `step` method returns. This was done to
improve consistency with the other environments.
@pseudo-rnd-thoughts
Copy link
Member

@Kallinteris-Andreas Do we want to add the info ideas to v4 as well?

@Kallinteris-Andreas
Copy link
Collaborator

i would rather not change the functionality of v4

@pseudo-rnd-thoughts
Copy link
Member

@rickstaa Thanks for the PR but we are going to keep v4 as it is, we are hopefully releasing mujoco v5 environments that will include these changes

@pseudo-rnd-thoughts pseudo-rnd-thoughts mentioned this pull request Jul 12, 2023
Closed
10 tasks
@rickstaa
Copy link
Author

@rickstaa Thanks for the PR but we are going to keep v4 as it is, we are hopefully releasing mujoco v5 environments that will include these changes

No problem I was not aware of #572. Thanks!

@rickstaa rickstaa deleted the extend_hopper_info branch July 13, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rickstaa @pseudo-rnd-thoughts @Kallinteris-Andreas