Vertically connected hulls are not considered connected for purposes of fire detection.

[BlackMoons]

Disclaimers

• I have searched the issue tracker to check if the issue has already been reported.
• My issue happened while using mods.

What happened?

When using smoke detectors, two hulls, one over the other do not count as 'connected'

Take for example the following:

when a fire is spawned in the lower hull, you get the following:

Where the detectors in the room to the left detect the fire just fine, but the ones in the hull above the fire don't detect anything until that hull catches on fire.

Reproduction steps

Firebug.zip

Open submarine, use ambientlighting 0.5,0.5,0.5,0.5 so you can see, use fire command to spawn fire.

Observe that upper smoke detector lights do not turn on until the hull they are in catches fire.

Bug prevalence

Happens every time I play

Single player or multiplayer?

Single player

-

No response

Version

v1.3.0.4

-

No response

Which operating system did you encounter this bug on?

Windows

Relevant error messages and crash reports

No response

[BlackMoons]

Additional testing:

Expected side hulls to fully light up when I lit the center lower hull on fire... What actually happened was (Incorrect behavior):

Looks like smoke detectors don't detect fire if the hull the fire is in, is lower then the position of the smoke detector.

When the fire spread into the upper center hull, this happened (Correct behavior):

And setting a fire in the right hull resulted in (Correct behavior):

[SomeRandomNoobKekeke]

I don't get what you expect to be the correct behavior, e.g. why on last screen 3 left lights are off? why is this correct?

Like, did you mean all lights in all connected hulls should turn on instantly?
Or all lights in a square around fire?
Or you did mean they should detect smoke like in real life?
https://www.youtube.com/watch?v=ACjtIa5MU5M

[SomeRandomNoobKekeke]

Looks like smoke detectors don't detect fire if the hull the fire is in, is lower then the position of the smoke detector.

hmm...
https://github.com/FakeFishGames/Barotrauma/blob/master/Barotrauma/BarotraumaShared/SharedSource/Items/Components/Signal/SmokeDetector.cs#L71

https://github.com/FakeFishGames/Barotrauma/blob/master/Barotrauma/BarotraumaShared/SharedSource/Map/FireSource.cs#L342

Yea, i think because of this: worldPosition.Y > hull.WorldRect.Y) return false;

So it's damaging everything from top to bottom of its hull, otherwise it will damage items through walls

[BlackMoons]

Correct behavior should be that all lights within 5M of the fire, within connected hulls should be on.

In the last pic the left most lights don't light up because they are further away then 5m, but all the lights in the square do.

Its incorrect that the 'connected hull' above the middle hull doesn't light up when the fire is in the center hull below it. Its correct when fire is to the left or right hull.