-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add form label component #201
Comments
Would this be something that's attached to inputs that a consumer could opt into with a prop? <Input medium label='Username' /> Or are you envisioning a separate component that the consumer would add themselves? <Label>Username</Label>
<Input medium /> |
It would simply be a styled <Label>
Username
<Input />
</Label> |
I can wait to see the final implementation but I think I have something to learn here. If it is just a label how will you control the vertical space between the label text and the top of the input? (In my implementation I used the label for layout and wrapped the text in its own div for the text style and spacing via margin-bottom.) |
Found a spec that confirms 4px spacing: |
Label
Describe the proposed API:
Export a
styled.label
with appropriate styling defaults set.Are there existing specs or designs?
https://app.zeplin.io/project/58a23c2d4597afb248c13a43/screen/59ee876e4582a457c39dbefe, but it violates the spacing scale by using a 6px margin. We should work with Amber to choose between 4px or 8px.
The text was updated successfully, but these errors were encountered: