Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add form label component #201

Open
bryanrsmith opened this issue Jul 16, 2019 · 5 comments
Open

Add form label component #201

bryanrsmith opened this issue Jul 16, 2019 · 5 comments
Labels
discussion-wanted Comments and discussion are welcome enhancement New feature or request

Comments

@bryanrsmith
Copy link
Contributor

Label

@bryanrsmith bryanrsmith added enhancement New feature or request discussion-wanted Comments and discussion are welcome labels Jul 16, 2019
@bryanrsmith
Copy link
Contributor Author

@smaxa20
Copy link
Contributor

smaxa20 commented Jul 16, 2019

Would this be something that's attached to inputs that a consumer could opt into with a prop?

<Input medium label='Username' />

Or are you envisioning a separate component that the consumer would add themselves?

<Label>Username</Label>
<Input medium />

@bryanrsmith
Copy link
Contributor Author

It would simply be a styled label, so

<Label>
    Username
    <Input />
</Label>

@LawrenceRafferty
Copy link

I can wait to see the final implementation but I think I have something to learn here. If it is just a label how will you control the vertical space between the label text and the top of the input? (In my implementation I used the label for layout and wrapped the text in its own div for the text style and spacing via margin-bottom.)

@RobertBolender
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion-wanted Comments and discussion are welcome enhancement New feature or request
Development

No branches or pull requests

4 participants