Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix URC parsing issues #214

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix URC parsing issues #214

wants to merge 2 commits into from

Conversation

t-moe
Copy link
Contributor

@t-moe t-moe commented Oct 1, 2024

Closes #213

Please carefully review especially the 2nd commit. I'm not sure if this change causes unintended consequences!

@t-moe t-moe marked this pull request as draft October 1, 2024 12:01
@t-moe t-moe marked this pull request as ready for review October 2, 2024 14:35
@TomDeRybel TomDeRybel mentioned this pull request Nov 18, 2024
Open
@MathiasKoch
Copy link
Member

Hi!
Thank you for this contribution, and sorry about not reviewing this yet! I have been swamped lately, but it should clear up a bit soon, and I will prioritize reviewing this.
Initially it looks reasonable, I just want to test it out on our different devices to verify behaviour 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parsing issues
2 participants
@t-moe @MathiasKoch