Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backtank is not hidden when the player chestplate is hidden #1261

Open
GibrielS opened this issue Jan 4, 2024 · 2 comments
Open

Backtank is not hidden when the player chestplate is hidden #1261

GibrielS opened this issue Jan 4, 2024 · 2 comments
Labels
status: needs testing Issue needs testing type: bug Issue where something isn't working

Comments

@GibrielS
Copy link

GibrielS commented Jan 4, 2024

Describe the Bug

the copper backtanks cannot be modified by figura models - as they are not hidden if vanilla chestplates are hidden

attached is the figura model I used - it hides the vanilla chestplate's center, which should hide the backtank and the middle section of the netherite chestplate added to the netherite backtank.
create mod.zip

In scripts/run.lua,

vanilla_model.CHESTPLATE_BODY should affect the backtank, and the middle section of the netherite chestplate added to the netherite backtank, not the arm covers.

vanilla_model.CHESTPLATE should affect the backtank, and all sections of the netherite chestplate added to the netherite backtank.

Reproduction Steps

  1. activate the model in figura
  2. wear a copper backtank
    X backtanks appear despite the chestplate body part being hidden
    X netherite chestplate added to netherite backtank also appears despite being set to hide.
    ...

Expected Result

The backtank would hide because I have hidden the vanilla model parts.

vanilla_model.CHESTPLATE:setVisible(false) should hide all chestplates
vanilla_model.CHESTPLATE_BODY:setVisible(false) should hide all chestplate bodies

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

Ubuntu 23.10 (Linux), (shouldn't be relevant)

Mod Version

0.5.1d

Minecraft Version

1.20.1

Other Mods

figura

Additional Context

Create's goggles seem to work fine though.

@GibrielS GibrielS added the type: bug Issue where something isn't working label Jan 4, 2024
@IThundxr
Copy link
Member

IThundxr commented Feb 8, 2024

Report to forge repo as this will affect it aswell

@GibrielS
Copy link
Author

GibrielS commented Feb 8, 2024

Report to forge repo as this will affect it aswell

this isn’t confirmed, if you do confirm this, you can report it.

@TropheusJ TropheusJ added the type: upstream This is inherited from upstream Forge Create. It is highly unlikely we will change it. label Sep 30, 2024
@TropheusJ TropheusJ changed the title Figura compatability issue - fabric 1.20.1 Backtank is not hidden when the player chestplate is hidden Sep 30, 2024
@TropheusJ TropheusJ added status: needs testing Issue needs testing and removed type: upstream This is inherited from upstream Forge Create. It is highly unlikely we will change it. labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs testing Issue needs testing type: bug Issue where something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants