Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steering names are inconsistent #3514

Open
haykam821 opened this issue Feb 22, 2023 · 0 comments
Open

Steering names are inconsistent #3514

haykam821 opened this issue Feb 22, 2023 · 0 comments
Labels
bug Fixes or discusses a bug within the mappings discussion

Comments

@haykam821
Copy link
Contributor

haykam821 commented Feb 22, 2023

Currently, steering names are somewhat inconsistent and do not sufficiently clarify how steering is controlled by the entity or its passenger. In particular:

  • StriderEntity#canEntityControl is the same as PigEntity#canBeControlledByRider
  • Entity#getPrimaryPassenger acts more like a steering passenger than a primary passenger. Even when this is null, passengers can steer the entity with their own movement. Players use this to override the movement entirely with client-side movement.

Discussion of how these names can be improved would be appreciated.

@haykam821 haykam821 added bug Fixes or discusses a bug within the mappings discussion labels Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes or discusses a bug within the mappings discussion
Projects
None yet
Development

No branches or pull requests

1 participant