Convention drink tags

[TheDeathlyCow]

This is a request to add new conventional item tags for drinks. There are a couple tags already for this, namely #c:buckets/milk, #c:potions, and #c:potions/bottle. However, many mods like Farmer's Delight (and its many add-ons), Let's Do (a whole series of mods, many of which add drinks), Brewery, and Dehydration (just to name a few) also add drinks of their own that often do not fall under vanilla categories. I would like Fabric API to add a new drinks subfolder of tags with greater depth for drinks, similar to the foods tags, though most of these tags would be empty.

Here are some of the tags I would like to see, but I would like to get input on what further tags could be added (since there are probably a few I am missing here):

• #c:drinks for all drinks (similar to #c:foods)
• #c:drinks/water for drinks that are mostly water - including potions and ominous bottles (potentially).
• #c:drinks/milk for milk
• #c:drinks/coffee for coffee
• #c:drinks/caffeinated for drinks that provide caffeine, including coffee and energy drinks
• #c:drinks/tea for tea
• #c:drinks/hot_chocolate for hot chocolate/hot cocoa
• #c:drinks/smoothie for milk shakes and smoothies
• #c:drinks/juice for all juices
• #c:drinks/soda for all sodas
• There could be more, but at least creating this folder should set a standard that makes it easier for mod authors to add more drinks of their own.

I'd also propose adding tags for alcoholic drinks. However, this may be difficult to add given Minecraft's age rating/usage policy. Regardless, there are many mods out there for brewing and alcoholic drinks, so I still think this would be a worthwhile inclusion.

• #c:drinks/alcohol for all alcoholic drinks
• #c:drinks/alcohol/wine for all wines, including mead
• #c:drinks/alcohol/beer for all beers and ales
• #c:drinks/alcohol/cider for all ciders
• #c:drinks/alcohol/cocktail for all cocktails
• #c:drinks/alcohol/spirit for all spirits like rum, tequila, and vodka.

My Personal Use Case

I am working on a thirst mod addon for my temperature mods Frostiful and Scorchful (https://github.com/TheDeathlyCow/thirstful/). This mod will focus on adding a lot of effects to these sorts of drinks. For example, quenching thirst (from water, milk, juice, and soda), warming and cooling (coffee, tea, hot cocoa, smoothies), diuretics (caffeine, alcohol), and vasodilation (a faux warming effect caused by drinking alcohol). I would like this thirst mod to be able to work with as many food and drink mods out of the box as possible, without requiring players/mod pack authors to have to manually configure large amounts of tags. My suggestions for tags are mostly based on my ideas for this particular mod, but I have tried to make it as widely applicable as possible. Still, I am very open to further suggestions.

Other Considerations

• These mods could simply define their own conventional tags for drinks. However, I think this could lead to some deviations between mods/namespace pollution and that inclusion in Fabric API/NeoForge would better standardise this.
• Drinks could be added to the foods tags, but I think drinks differ from foods in that drinks both use the drink action and do not generally provide nutrition/saturation (that is, they do not have a food component).

[TheDeathlyCow]

Here is a revised list of tags based on some discussions had in the NeoForge issue:

This list is based more on providing examples for standardization rather than exhaustively listing all drinks. The Javadoc of the tag keys could also be a good place to formally describe these standards. However, I know that I myself don't always look at the javadoc since I don't actually use datagen at all - I usually just look at the rendered tags (though perhaps that is not a good practice on my part haha).

• #c:drinks for all drinkable items (similar to #c:foods)
• #c:drinks/water for drinkable water items (potions)
• #c:drinks/milk for drinkable milk items (milk bucket)
• #c:drinks/honey for drinkable honey items (honey bottle)
• #c:drinks/magic for drinks that are magical in nature and give status effects when consumed. includes potions and ominous bottles
• #c:drinks/juice for all juices (will be empty)

The follow tags demonstrate how to differentiate subtypes of drinks using juices that have a vanilla ingredient

• #c:drinks/juice/apple
• #c:drinks/juice/beetroot
• #c:drinks/juice/carrot
• #c:drinks/juice/watermelon
• Edit: #c:drinks/magic/ominous for the ominous bottle may be a useful inclusion as well

I also propose adding drink-containing tags, similar to the ore_rates tag I guess.

• #c:drink_containing/bucket for all drinkable buckets (milk)
• #c:drink_containing/bottle for all drinkable bottles (potions, honey bottles, ominous bottles)

There may be a better way to differentiate buckets and bottled drinks. My solution is based on checking combinations like #c:drinks/honey && #c:drink_containing/bucket for drinkable honey buckets.