Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModelLoadingEventDispatcher.BlockStateResolverContext#setModel() does not null-check the given blockstate #4310

Open
XFactHD opened this issue Dec 19, 2024 · 0 comments · May be fixed by #4320
Assignees
Labels
bug Something isn't working

Comments

@XFactHD
Copy link

XFactHD commented Dec 19, 2024

ModelLoadingEventDispatcher.BlockStateResolverContext#setModel() null-checks the given model a second time instead of null-checking the given blockstate:

public void setModel(BlockState state, GroupableModel model) {
Objects.requireNonNull(model, "state cannot be null");
Objects.requireNonNull(model, "model cannot be null");

FAPI version: 0.112.2+1.21.4

@PepperCode1 PepperCode1 added the bug Something isn't working label Dec 19, 2024
@PepperCode1 PepperCode1 self-assigned this Dec 19, 2024
@modmuss50 modmuss50 linked a pull request Dec 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants