c:coal appended minecraft:coals tag breaking recipes

[ffuentesm]

adding c:coal to the #minecraft:coals tag is breaking some of my recipes

https://github.com/FabricMC/fabric/blob/1.21.1/fabric-convention-tags-v2/src/generated/resources/data/c/tags/item/coal.json

This is causing the c:coal tag to be added to charcoal and coal coke items from other mods I have. It breaks the recipes that use the c:charcoal and c:coal_coke tags. To fix that, you just have to unappend the c:coal from the #minecraft:coals tag and instead add the minecraft:coal item.

Could you make it this instead?

{
"values": [
{
"id": "minecraft:coal",
"required": false
}
]
}

[Juuxel]

I think the tag contents are correct. A better solution for recipes is to take minecraft:coal directly if you only want it to work with that item, or to use difference ingredients:

fabric/fabric-recipe-api-v1/src/main/java/net/fabricmc/fabric/api/recipe/v1/ingredient/DefaultCustomIngredients.java

Lines 85 to 97 in 4fc7e41

	/**
	* Creates an ingredient that matches if its base ingredient matches, and its subtracted ingredient <strong>does not</strong> match.
	*
	* <p>The JSON format is as follows:
	* <pre>{@code
	* {
	* "fabric:type": "fabric:difference",
	* "base": // base ingredient,
	* "subtracted": // subtracted ingredient
	* }
	* }</pre>
	*/
	public static Ingredient difference(Ingredient base, Ingredient subtracted) {

[ffuentesm]

The problem that I have is due to c:coal being automatically attached to the mineacraft:coals tag.
This causes charcoal, and any other item that used the Minecraft:coals to inherit the c;coal tag.

I use a unification mod to merge duplicate items from the game, and due to that, charcoal (and other items that use mineacraft:coals ) get removed from the game due to inheriting the c:coal tag. Basically, burning logs result into coal being produced. Coal Coke is removed from the game due to this. A lot of problems arise due to this.

btw: the mods that add those other coal types, name those coals with c:charcoal and c:coal_coke tags to use.
Now due to how c:coal is being inherited, it gets added to those other coal types.