Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Fabric Networking API #3505

Closed
christopherplaysminecraft opened this issue Jan 3, 2024 · 6 comments · Fixed by #3508
Closed

Issue with Fabric Networking API #3505

christopherplaysminecraft opened this issue Jan 3, 2024 · 6 comments · Fixed by #3508
Labels
bug Something isn't working priority:high High priority PRs that need review and work now. Review these first.

Comments

@christopherplaysminecraft

I've been getting random disconnects from Hypixel for the past week and I cannot seem to find out what's causing those disconnects, they happen every 5 Minutes to 3 Hours for seemingly no reason.

The only error message I'm getting is this:
io.netty.util.IllegalReferenceCountException: refCnt: 0

Looking into the logs gives this, but nothing else
fabricapi-kicks.txt

I remember getting disconnected with a slighty different error
io.netty.util.IllegalReferenceCountException: refCnt: 0, decrement: 1
But I could't find anything in the logs other than that exact message

Minecraft 1.20.4
Fabric-Loader 0.15.3
Fabric-API 0.92.0
Java 21

@modmuss50
Copy link
Member

modmuss50 commented Jan 3, 2024

Can you provide the full log for this please, including any mods you are using?

Adding the following JVM option may aid with debugging this issue: -Dio.netty.leakDetection.level=paranoid. Check the game log for anything starting with LEAK:.

@modmuss50 modmuss50 added the bug Something isn't working label Jan 3, 2024
@christopherplaysminecraft
Copy link
Author

Can you provide the full log for this please

Unfortunately not, because the logs contain some private chats, which would take hours to clear up
Would a log showing the game start help?

including any mods you are using?

I have tested different combinations of those mods, even removing both FAPI and ViaFabricPlus, and I still got disconnected, then I realized NoChatReports uses Fabric Networking API, I don't know if that's relevant though
Haven't been able to test any further (and I would also like to keep NoChatReports)

  • Fabric API [0.92.0+1.20.4]
  • FerriteCore [6.0.3]
  • Sodium [0.5.5]
  • ImmediatelyFast [1.2.8+1.20.4]
  • ViaFabricPlus [3.0.2]
  • No Chat Reports [1.20.4-v2.5.0]
  • ModernFix [5.11.1+mc1.20.4]

Adding the following JVM option may aid with debugging this issue
Check the game log for anything starting with LEAK:.

In general or only in cases where I get disconnected? (After having added the JVMarg of couse)

@apple502j
Copy link
Contributor

@christopherplaysminecraft No, please provide logs for the entire gameplay.

@modmuss50
Copy link
Member

Can you maybe try wihout ViaFabricPlus and/or No Chat Reports, I expect these mods will make heavy adjustments to the networking stack. Im not sure what some of those peformance mods do either. I think this should be moved to a support disucssion, unless it can be reproduced with just fabric api, or with a minimal mod that shows a bug.

That system prop should force netty to run its leak detection on all packets basically, possibly making it crash more often, or providing extra details in the log.

@modmuss50 modmuss50 added the support Issues closed due to being a support request. label Jan 3, 2024
Copy link

github-actions bot commented Jan 3, 2024

👋 We use the issue tracker exclusively for final bug reports and feature requests. However, this issue appears to be better suited for either a discussion thread, or a message on our discord server. Please post your request on one of these, and the conversation can continue there.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 3, 2024
@modmuss50 modmuss50 reopened this Jan 4, 2024
@modmuss50
Copy link
Member

I have been able to reproduce this issue, in FAPI's dev env.
Screenshot 2024-01-04 at 22 30 25

@modmuss50 modmuss50 added priority:high High priority PRs that need review and work now. Review these first. and removed support Issues closed due to being a support request. labels Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:high High priority PRs that need review and work now. Review these first.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants