Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary recreation of identifiers in the VillagerTypeHelper.register method #3408

Closed
haykam821 opened this issue Nov 7, 2023 · 1 comment · Fixed by #3597
Closed
Labels
priority:low Low priority PRs that don't immediately need to be resolved

Comments

@haykam821
Copy link
Contributor

The deprecated VillagerTypeHelper.register method uses new Identifier(id.toString()) rather than id:

public static VillagerType register(Identifier id) {
Objects.requireNonNull(id, "Id of villager type cannot be null");
return Registry.register(Registries.VILLAGER_TYPE, new Identifier(id.toString()), new VillagerType(id.toString()));
}

There shouldn't be any observable difference between the two arguments, but the behavior is a bit silly and seems to have been introduced in 1e232e1.

@modmuss50 modmuss50 added the priority:low Low priority PRs that don't immediately need to be resolved label Nov 7, 2023
@modmuss50
Copy link
Member

Its almost not worth the effort to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low Low priority PRs that don't immediately need to be resolved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants