Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Data-Driven Biome Modification API #3316

Open
maityyy opened this issue Sep 14, 2023 · 1 comment
Open

[Suggestion] Data-Driven Biome Modification API #3316

maityyy opened this issue Sep 14, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@maityyy
Copy link
Contributor

maityyy commented Sep 14, 2023

The Biome Modification API is most often used for simple operations like add/remove/replace a feature/mob/etc., which, IMO, can be implemented as simple JSON files in data packs. Datagen can also be used, since most worldgen is implemented through data packs and datagen. In fact, NeoForge already has similar functionality and we can turn to its experience.

Idk if it is worth redoing the entire API or just adding the ability to create simple modifications via JSON files. I personally would not want to force the use of a datagen, since there are many simple mods that want to remain that way, although they can write a few files by hand + the current API may be difficult to expand. In any case, BMAPI is marked as an experimental API, so we have a lot of freedom and can indirectly opt out of some features.

I also think this is a great opportunity to unify the JSON file format with the NeoForge API

@maityyy maityyy changed the title Data-Driven Biome Modification API [Suggestion] Data-Driven Biome Modification API Sep 14, 2023
@Juuxel Juuxel added the enhancement New feature or request label Sep 14, 2023
@modmuss50
Copy link
Member

A data driven system could possibly be built ontop of the existing API to provide the common operations. I dont think we should be making breaking changes or removing the existing API. Even its made stable that does not prevent v2 module, or new additions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants