When i try to use my custom (client only) commands in 1.19, it keeps saying that it is an incompleete/invalid command.

[TheBosoYolo]

I have this code right here:
public static void RegisterCommands() { ClientCommandRegistrationCallback.EVENT.register((dispatcher, registryAccess) -> dispatcher.register(literal("something") .then(literal("somethingelse") .executes(MyFile.SomeFunctionHere())))); }
can someone help me, what is wrong with this code why it keeps saying that. If you coment anything it would mean a HUGE help to me. Thanks

[warjort]

Let me format it like this

dispatcher.register(
    literal("something") .then(
        literal("somethingelse") 
        .executes(MyFile.SomeFunctionHere())
    )
)

So you can see you have a command that needs 2 literals. You would enter it as
/something somethingelse

You know you can use tab to autocomplete commands or give suggested completions?

[TheBosoYolo]

Btw what does context - > blablabla mean?

[warjort]

The code you have written says I am going to use whatever SomeFunctionHere returns as the command to execute.
You say you are returning null which tells minecraft there is no such command.

 .executes(MyFile.SomeFunctionHere()) // means call the method then use the result as the command

If you actually want SomeFunctionHere as the command then you would write

 .executes(MyFile::SomeFunctionHere) // means use that function as the command to execute

this is a method reference not a method call like you have.
But you will need to make sure SomeFunctionHere has the correct method signature for a command.

Btw what does context - > blablabla mean?

Its an anonymous function - more commonly known as a lambda function.
In this case a function that takes one parameter - the context
https://docs.oracle.com/javase/tutorial/java/javaOO/lambdaexpressions.html
So instead of giving it the method reference to elsewhere, the function is defined inline.

[Sjouwer]

I recommend this guide which explains how commands work:
https://fabricmc.net/wiki/tutorial:commands

[TheBosoYolo]

Here is another footage of me trying to use (MyFile::SomeFunctionHere):

2022-06-18.20-04-03.mp4

Still can't figure out whats wrong... :(

[warjort]

Like I said above, if you want to use method references:
But you will need to make sure SomeFunctionHere has the correct method signature for a command.
So your method's signature for a client command needs to look like this:

	public static int something(CommandContext<FabricClientCommandSource> context) {
		LOGGER.info("Something");
		return 0;
	}

This is the named version of the anonymous lambda I posted before.

[warjort]

Aside:
In the latest video you posted, you show the client commands getting registered from your mod initializer and you are placing a client command method in your normal mod code.
This is incorrect. The client command stuff is only available on the client. You need to put it in a client mod initializer
https://fabricmc.net/wiki/documentation:entrypoint

If you leave it as it is, it will crash if your try to load your mod on a dedicated server.

[TheBosoYolo]

ok and how do i get rid of it

Thats just a helper method so you can list just the client only commands by typing /fcc help or the longer name.

fabric/fabric-command-api-v2/src/client/java/net/fabricmc/fabric/impl/command/client/ClientCommandInternals.java

Line 141 in 1c5dd50

* on the command dispatcher. Also registers a {@code /fcc help} command if there are other commands present.

EDIT: I dont understand java very well, but other client command mods do not include /fcc so there must be a way to get rid of it

[warjort]

Its not your command. Why do you want to get rid of it?
Its just the same as typing /help to list all commands.

I'm sure there are ways to remove other people's commands but I doubt it is straightforward, its not a normal operation.
I'll leave that for you to research, it will involve getting hold of the root command node from the command dispatcher and removing the data from it, maybe it will need a mixin to make it mutable?

[warjort]

I dont understand java very well, but other client command mods do not include /fcc so there must be a way to get rid of it

Its added by fabric "automagically" when anybody registers a client command. So yes it will be there if other mods have client commands.

[TheBosoYolo]

ok, thanks for the help. But you understand my situation, i want a peaceful mod and some random UGLY command (/fabric-command-api-v2:client) just apears in my mod out of thin air

[Juuxel]

It's not a "random UGLY command", it's the client command version of /help and cannot be disabled, just like you can't disable the serverside help command.

The reason why it's not always there to begin with is that it's only needed if client commands are registered.