[1.18] BiomeSelectors.foundInOverworld() doesn't work with datapack mods?

[kwpugh]

I have found that BiomeSelectors.foundInOverworld() doesn't seem to insert ores into biomes created by data packs.

Terralith in particular is an example. It replaces the overworld dimension type json. My ores from Gobber and MoreGems mod would not show up in Terralith biomes.

To force it, I created a custom predicate to select biomes that are not nether or the end and then my ores spawned in those biomes.

my code:
public static Predicate<BiomeSelectionContext> customSelection() { return context -> !NetherBiomes.canGenerateInNether(context.getBiomeKey()) && !TheEndBiomes.canGenerateInTheEnd(context.getBiomeKey()) && context.getBiome().getCategory() != Biome.Category.NONE; }

my ore gen code: https://github.com/kwpugh/gobber_fabric-1.17/tree/1.18.0/src/main/java/com/kwpugh/gobber2/world

Is this already a known issue?

[warjort]

I have found that BiomeSelectors.foundInOverworld() doesn't seem to insert ores into biomes created by data packs.

That method name is kind of misleading.
It really sort of means foundInVanillaOverworldBiomes()

See the (long) discussion here:
#1703

The originator of that thread ended up using something similiar to your code:

getCategory() != Biome.Category.THEEND && getCategory() != Biome.Category.NETHER

[kwpugh]

ok. Might also let @modmuss50 know as well, because Tech Reborn has the same problem with not spawning in those biomes, it uses BiomeSelectors.foundInOverworld() for ore gen as well.

[kwpugh]

So the tutorial guides devs to add ore with the BiomeSelectors.foundInOverworld(), is that NOT what they should be using?

[warjort]

So the tutorial guides devs to add ore with the BiomeSelectors.foundInOverworld(), is that NOT what they should be using?

In general its pretty hard to write a simple tutorial and also cover all nuances of every possible configuration.

If you mean this;
https://fabricmc.net/wiki/tutorial:ores

It's a wiki.

Why don't you update it to add a comment that the simple approach shown doesn't necessarily work with modded/datapack dimensions?
You could even add a section/example showing how to do it more generically using custom biome selectors.

[warjort]

ok. Might also let @modmuss50 know as well, because Tech Reborn has the same problem

You can raise it on its github issues.
https://github.com/TechReborn/TechReborn/issues