Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to edit or remove instructor records #8

Open
denistex opened this issue Feb 9, 2017 · 1 comment
Open

Add ability to edit or remove instructor records #8

denistex opened this issue Feb 9, 2017 · 1 comment
Assignees
Milestone

Comments

@denistex
Copy link
Collaborator

denistex commented Feb 9, 2017

No description provided.

@denistex denistex added this to the 1.0-rc3 milestone Feb 9, 2017
@denistex denistex self-assigned this Feb 9, 2017
@pavelsr
Copy link
Member

pavelsr commented Mar 19, 2017

I think there is two possible formats of storing information about who can edit or remove instructor records at bot.pl.json.

  1. Add is_root flag to instructor:
{
            "first_name": "Pavel",
            "last_name": "Serikov",
            "gmail": "[email protected]",
            "phone_number": "+79885851900",
            "telegram_id": "@serikoff",
            "calendars": [ "Lasersaur", "Dobot"],
            "is_root": 1
        },
  1. Make a separate managers: [] section because manager isn't essential instructor.
"managers": [
{
            "first_name": "Pavel",
            "last_name": "Serikov",
            "gmail": "[email protected]", // is gmail field needed for manager ?
            "phone_number": "+79885851900", //
            "telegram_id": "@serikoff", //
        },

However in case of using first format we can add manager as instructor with an empty calendars array.

"instructors": [
{
            "first_name": "Pavel",
            "last_name": "Serikov",
            "gmail": "[email protected]",
            "phone_number": "+79885851900",
            "telegram_id": "@serikoff",
            "calendars": [ ],
            "is_root": 1
        },
...
]

I think first option is better. But maybe empty calendars list may affect on code.

@denis-it, which option do you think is better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants