Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readUV prints to serial #1

Open
benibr opened this issue Mar 23, 2020 · 0 comments
Open

readUV prints to serial #1

benibr opened this issue Mar 23, 2020 · 0 comments

Comments

@benibr
Copy link

benibr commented Mar 23, 2020

Hi,
Using your lib saves me a lot of time, thank you very much for writing and publishing this!

Is there any particular reason why the readUV function prints the value it reads to the serial line?
When one uses the serial as a user interface, this is troubling.
I'd suggest to remove this line and let print the user the value if it is wanted.
https://github.com/FaBoPlatform/FaBoUV-Si1132-Library/blob/master/src/FaBoUV_Si1132.cpp#L144

Cheers,
Beni
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix UV measurement and provide raw output CarlosGS/FaBoUV-Si1132-Library
1 participant
@benibr