add key request to protocol support

[d47081]

well, have removed the warning, but what's next to do with the client key passing

[a1batross]

I don't recommend trying to patch this code, since it will be replaced by Rust reimplementation on the main master server. Of course, you could hack on it, like IPv6 support patch is mostly fine but it makes no sense to fix bugs in it. вс, 24 дек. 2023 г., 23:00 d47081 ***@***.***>:

…

well, have removed the warning, but what's next to do with the client key passing ------------------------------ You can view, comment on, or merge this pull request online at: #6 Commit Summary - 4501ee1 <4501ee1> add key request to protocol support File Changes (1 file <https://github.com/FWGS/pymaster/pull/6/files>) - *M* pymaster.py <https://github.com/FWGS/pymaster/pull/6/files#diff-f752aa366692b0bd4683a00d454559cf5e89969e1afcdcc8b0d8546749aa882f> (3) Patch Links: - https://github.com/FWGS/pymaster/pull/6.patch - https://github.com/FWGS/pymaster/pull/6.diff — Reply to this email directly, view it on GitHub <#6>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAYQTAP6W6UX3M2QSUOTIWLYLCCWFAVCNFSM6AAAAABBBXOJPCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA2TKMRQGA4TCOI> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[d47081]

I'm just trying to setup master server able to search servers in Yggdrasil network could not be listed by mentality.rip

With those 2-6 PRs I think it close to run this server, but looks I'm stuck with protocol misunderstanding as different - at least it should contain key string https://developer.valvesoftware.com/wiki/Master_Server_Query_Protocol

By current PR trying to fix this issue FWGS/xash3d-fwgs#1542

Is there any plans to share the rust version soon?

[a1batross]

Our protocol is loosely based on that document and doesn't match it. Not only that, the original protocol never had IPv6 to begin with. I also wanted to implement some kind of compression for v6 addresses, and packet split, so the UDP packet won't get lost because of it's size. Rust version will be run soon, and will be opensourced. пн, 25 дек. 2023 г., 10:33 d47081 ***@***.***>:

…

I'm just trying to setup master server able to search servers in Yggdrasil network could not be listed by mentality.rip With those 2-6 PRs I think it close to run this server, but looks I'm stuck with protocol misunderstanding as different https://developer.valvesoftware.com/wiki/Master_Server_Query_Protocol By current PR trying to fix this issue FWGS/xash3d-fwgs#1542 <FWGS/xash3d-fwgs#1542> Is there any plans to share the rust version soon? — Reply to this email directly, view it on GitHub <#6 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAYQTAPDQL6YA5XLFM7VXY3YLET4ZAVCNFSM6AAAAABBBXOJPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRYHAZDCNRWHA> . You are receiving this because you commented. Message ID: ***@***.***>

[d47081]

Yes, just found that protocol definitions does not correspond xash3d client definitions:
https://github.com/FWGS/pymaster/blob/master/protocol.py

I have changed queryPacketHeader to b'\x7f\x0a' but not sure it's correct.

Could you please advice about this file corrections just?

Thank you!

class MasterProtocol:
	# Client To Master
	clientQuery = b'1'

	# Server To Master
	challengeRequest = b'q\xFF'
	addServer = b'0\n'
	removeServer = b'\x62\x0A'

	# Master To Client
	queryPacketHeader = b'\xff\xff\xff\xff\x7f\x0a'

	# Master To Server
	challengePacketHeader = b'\xff\xff\xff\xff\x73\x0a'

[a1batross]

The \xff\xff\xff\xff is important because it's a special header for connectionless packets in the engine. Everything that goes to client and server must have that header.

[d47081]

Thank you, just fixed #7

[a1batross]

Sorry, but it's not a fix.

The engine expects an "f". The hex value for ASCII character 'f' is 0x66. 0x0a gets ignored by the engine, but it might not be ignored with third-party tools.

Anyway, better wait for Rust version. It's much cleaner than this.

[d47081]

As understand protocol requires something like

packet = MasterProtocol.queryPacketHeader
...
packet += b"\x7f"
packet += key # but I don't know how this value should be packed as gives 'invalid key' on xash3d side

maybe like this one
packet = b"\x7f" + key.encode('latin_1')

[d47081]

Well, I have added this draft by commit

Now it's no errors in xash debug
Warning: unexpected server list packet from ... (invalid key)

If the random key is 45c6cbbe maybe this part must have format \x7f\x45\xc6\xcb\xbe
FWGS/xash3d-fwgs#1542 (comment)

PS I have closed previous PR
PPS how long to wait for rust edition? Not sure it will published be soon...