-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GSS data in vehicle coordinate frame #178
Comments
At this moment the GSS is perfectly usable, therefore marking as low-prio. Before we implement this, we need a way to model the lateral velocity. Does anyone know how this could be done? |
It's very easy to implement, because you already have all necessary information. Right know the /fsds/testing_only/odom massage, which you also use for the GSS, contains already the lateral velocity but only in the global coordinate system. |
Sounds good! Do you want to make a pr, proposing a change to this file/line? |
Sure, I'll take a look at it. |
Hi @wahllca , we are planning to release the final version for competition tonight. Were you able to take a look at this? |
Hey @SijmenHuizenga , sorry I couldn't make it. I am currently very busy with exams and I didn't have time to test it properly. If you plan to use the vehicle coordinate system in the future you can use the quaternion Considering the remaining time, is it ok for you to use the global velocity vector in the GSS? |
@SijmenHuizenga I created a pr #186 in which I changed the velocity back to the global coordinate system. |
Thank you! I will check and merge it before release 👍 Amazing to hear you want to help and continue working on this this after comp <3 |
Hi @wahllca, do you still want to take a look at the gss and make it output data in the vehicle coordinate frame? |
Coordinate system changed from global to local car frame in #304 |
#161 added a GSS to the simulator. The assumption was made that the lateral velocity was 0 so that a trivial conversion between global velocities and body longitudinal velocity could be made (by just taking the norm). As shown in a real Kistler plot here, lateral velocities are certainly smaller than longitudinal velocities but are not negligible (in this bag they reach magnitudes of ~1m/s). These velocities can significantly impact the quality of state estimates and controllers.
The text was updated successfully, but these errors were encountered: