Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git submodule miniChRIS-docker, miniChRIS-podman, and charts to proper directory-names. #552

Open
chhsiao1981 opened this issue Apr 12, 2024 · 1 comment

Comments

@chhsiao1981
Copy link
Contributor

make.sh is a 1990s-style deployment setup.

In addition, I don't think it's good to put several .sh in the root-dir.

Thanks to @jennydaman's modern deployment setup in

miniChRIS-docker
miniChRIS-podman
charts

Perhaps we can:

  • git submodule miniChRIS-docker docker
  • git submodule miniChRIS-podman podman
  • git submodule charts helm
  • move the original bash-scripts to make/:

I understand that we do want to have some simple bash-scripts for deployment.
I would propose to have these scripts in deploy/:

  • deploy/install-docker.sh
  • deploy/uninstall-docker.sh
  • deploy/install-podman.sh
  • deploy/uninstall-podman.sh
  • deploy/install-helm.sh
  • deploy/uninstall-helm.sh
  • deploy/install-make.sh
  • deploy/uninstall-make.sh
@jennydaman
Copy link
Contributor

Hi @chhsiao1981 100% agree that ./make.sh should be rewritten for the modern era.

The various ways to run ChRIS are described here. https://chrisproject.org/docs/run

tl;dr ./make.sh is for backend development only, and primarily used by @jbernal0019 himself. The other methods: miniChRIS-docker, miniChRIS-podman, charts, and the documentation you find on https://chrisproject.org/docs, are suitable for "general users" and maintained by me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants