-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why the input of model is speed? #26
Comments
Hi @JackokieZhao, you are getting it correct, the model is taking the speed as input and I guess it's not a mistake, I experimented with both cases positions and speeds and I found model actually worked better with speeds, and you can look at it this way - speed is just distance when looked for unit time. I hope I'm able to resolve your doubt. |
Thanks for your answer ! In my opinion, the ADE of the positions dosen't equal the ADE of speed. We assume there are three positions p1, p2, p3, and corresponding speed v1, v2 (prediction results p1_, p2_, p3_, v1_, v2_). In general, the ADE of positions should be mean(|p1 - p1_| + |p2 - p2_| + |p3 - p3_|). And, I think this is the reason why the performance of position prediction is much lower than speed prediction. This is just a academic talk, and I am not aggressive or hostile in any way. Thanks a lot! |
Hi, thanks for the open source of your greate work. There remains a detail that I cannot understand, so I would appreciate it if you can explain it to be.
In my opinion, the line 260 in file 'baselineutils.py' means that the [0-2] columns in dim 2 denotes pedestrain positions while [2:4] columns in dim 2 denotes the speed of pedestrain.
inp_norm=np.concatenate((inp_te_np,inp_speed),2)
However, the input of model are [2:4] in dim 2, which means the input are speeds rather than positions of pedestrain.
inp=(batch['src'][:,1:,2:4].to(device)-mean.to(device))/std.to(device)
pred=model(inp, dec_inp, src_att, trg_att)
I don't know whether there is any mistick for the unserstanding, could you please expalin it to me ?
The text was updated successfully, but these errors were encountered: