Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All receivers (rec Record) need to operate on pointers not values #4

Open
zacsketches opened this issue Nov 20, 2018 · 1 comment
Open

All receivers (rec Record) need to operate on pointers not values #4

zacsketches opened this issue Nov 20, 2018 · 1 comment
Labels
Performance This might increase performance

Comments

@zacsketches
Copy link
Contributor

From @zacsketches on November 15, 2018 12:18

various operations on a Record may get called millions of times in a program. These should not be making value copies of the record. They should be operating on the Pointer to an existing Record.

Copied from original issue: FATHOM5/Seattle_Reasonable_Track2#28
@zacsketches zacsketches added the Performance This might increase performance label Nov 20, 2018
@zacsketches
Copy link
Contributor Author

Calling Record.Distance which is required for every result in the search for two-vessel interactions means that there are millions of record copies being made to support this operation.

@zacsketches zacsketches changed the title All receivers (r *Record) need to operate on pointers not values All receivers (rec Record) need to operate on pointers not values Nov 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Performance This might increase performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zacsketches